-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CommandAPI should use MinecraftServer#getCommands instead of MinecraftServer.vanillaCommandDispatcher #406
Comments
I notice that comment is from a Paper PR. If this change was applied, would the CommandAPI still work on Spigot? If not, I suppose we would just need to migrate calls to Also, does this change apply to Paper right now, or only after that PR is merged? |
Yes, this will still work on Spigot. The |
Description
As per this comment:
Expected code
Replace the use of
MINECRAFT_SERVER.vanillaCommandDispatcher
in NMS implementations ofNMS#getBrigadierDispatcher
CommandAPI/commandapi-nms/commandapi-1.19.3/src/main/java/dev/jorel/commandapi/nms/NMS_1_19_3_R2.java
Lines 395 to 398 in 2efd3a3
with
MINECRAFT_SERVER.getCommands()
:Extra details
No response
The text was updated successfully, but these errors were encountered: