Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Account Page UI Updates #3522

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix: Account Page UI Updates #3522

wants to merge 5 commits into from
+53 −20

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Oct 29, 2024 •
edited
Loading

Description

These fixes are only within the scope of what's been raised in issue #3509 and #3501.

Testing

  1. The mobile version of the Email Preferences field should follow the Figma designs:
image
  1. These components should have a 24px (gap-6) spacing in between them:
Screenshot 2024-10-29 at 22 26 11
  1. Rename "Advanced settings" to "Advanced"
image
  1. The H4 elements for the account pages should be brought back as per these Figma designs

Here's Crypto to fiat's H4: https://www.figma.com/design/C2grfQysdsYXz0j4rADR6K/Crypto-to-Fiat?node-id=4441-108444&t=9p1Uvq5xWxYFmdVW-4

  1. The horizontal divider should match the style of the horizontal divider found on the Colony Page sidebar
image

Resolves #3509

@rumzledz rumzledz self-assigned this Oct 29, 2024
@rumzledz rumzledz changed the title Fix/3509 user account UI fixes Fix: Account Page UI Updates Oct 29, 2024
@rumzledz rumzledz mentioned this pull request Oct 29, 2024
Open
@rumzledz rumzledz marked this pull request as ready for review October 29, 2024 16:40
@rumzledz rumzledz requested review from a team as code owners October 29, 2024 16:40
iamsamgibbs
iamsamgibbs requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes here!

The email address is stacked on mobile now, but the button should be full width:

Screenshot 2024-10-30 at 09 48 44

Figma:

Screenshot 2024-10-30 at 09 49 25

Spacing here is good:
Screenshot 2024-10-30 at 09 50 47

All pages have titles now:

Screenshot 2024-10-30 at 09 56 09 Screenshot 2024-10-30 at 09 56 12

The hr is the correct colour here now, but it is missing spacing above and below:

Screenshot 2024-10-30 at 09 58 08

Figma:
Screenshot 2024-10-30 at 10 04 39

@rumzledz
Copy link
Contributor Author

Thanks for spotting that @iamsamgibbs ! Pushed 🚀

@rumzledz rumzledz requested review from iamsamgibbs and a team October 30, 2024 10:54
iamsamgibbs
iamsamgibbs approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good now!

Screenshot 2024-10-30 at 10 57 40 Screenshot 2024-10-30 at 10 57 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsamgibbs iamsamgibbs iamsamgibbs approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@rumzledz rumzledz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QA UI: User account UI issues
2 participants
@rumzledz @iamsamgibbs