Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firmware reliability issue? #89

Open
JohnDMcMaster opened this issue Nov 2, 2022 · 1 comment
Open

Firmware reliability issue? #89

JohnDMcMaster opened this issue Nov 2, 2022 · 1 comment

Comments

@JohnDMcMaster
Copy link
Owner

A few times we've observed what looks like some sort of reliability issue. Ex: yesterday tried to set VPP and it wasn't working. Re-init device and starts working again. Think there is some low level issue that might be causing memory corruption
@JohnDMcMaster
Copy link
Owner Author

Found something interesting in comlib:com_readline()

                printf(out_buf);

This has several red flags:

  • printf()'ing a format string supplied by an external user. Ex: typing %s into the terminal may cause weird results
  • Newline terminal is dicy, but probably ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnDMcMaster