-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ezzif] The bus functions should probably take unsigned int* ns. #65
Comments
This wasn't so much about space savings, as it was easier to do math on byte values. Its still an open issue if we have more than one programmer how we'll organize the code and API consistency |
So we need to decide if pins are going to be unsigned char or unsigned int. Or uint8_t, since specifying the size of types is usually a good idea for embedded C! |
We should probably have a tag for code style "bugs". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just for consistency with the other functions. And in case we develop a programmer that can take more than 255 pins :)
I'm not convinced that the space savings is worth the inconsistency.
The text was updated successfully, but these errors were encountered: