Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 launcher no setting the environment on runtime #50

Open
pariaspe opened this issue Jul 14, 2023 · 3 comments
Open

ROS2 launcher no setting the environment on runtime #50

pariaspe opened this issue Jul 14, 2023 · 3 comments

Comments

@pariaspe
Copy link
Contributor

pariaspe commented Jul 14, 2023

If the ROS 2 environment is well built, this lines won't be needed:

def _set_environment(self):
resource_folders = [os.path.expandvars(path) for path in self.resource_folders]
model_folders = [os.path.expandvars(path) for path in self.model_folders]
plugin_folders = [os.path.expandvars(path) for path in self.plugin_folders]
os.environ["GAZEBO_RESOURCE_PATH"] = f"{os.environ.get('GAZEBO_RESOURCE_PATH', '')}:{':'.join(resource_folders)}"
os.environ["GAZEBO_MODEL_PATH"] = f"{os.environ.get('GAZEBO_MODEL_PATH', '')}:{':'.join(model_folders)}"
os.environ["GAZEBO_PLUGIN_PATH"] = f"{os.environ.get('GAZEBO_PLUGIN_PATH', '')}:{':'.join(plugin_folders)}"

@pariaspe pariaspe changed the title RAM ROS2 launcher no setting the environment on runtime ROS2 launcher no setting the environment on runtime Jul 14, 2023
@OscarMrZ
Copy link
Collaborator

This is solved in the last versions. I think this was not merged due to working in different branches right?

@pariaspe
Copy link
Contributor Author

When the PR was created envvars were still needed and we were waiting for some changes in the RoboticsInfrastructure repo. I believe this changes were made last December but I am not sure about the current status

@OscarMrZ
Copy link
Collaborator

Okey, then it is now definitely merged. I checked and the changes are merged in superthin-dev branch, could you check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants