Redundant upgrade checks for an upgrade segment if the version is the latest

[lewis-yeung]

Since v24, the upgrade check is always truly performed for an upgrade segment, so if OMP is on the latest version, the segment will be disabled and will not be cached, thus causing redundant upgrade checks and increasing the latency significantly when spawning new prompts.

Related code:

oh-my-posh/src/segments/upgrade.go

Lines 26 to 38 in 472bd6f

	func (u *Upgrade) Enabled() bool {
	u.Current = build.Version
	latest, err := u.checkUpdate(u.Current)
	if err != nil || u.Current == latest.Latest {
	return false
	}
	u.upgradeData = *latest
	u.Version = u.Latest
	return true
	}

oh-my-posh/src/config/segment.go

Lines 127 to 142 in 472bd6f

	func (segment *Segment) Render() {
	if !segment.Enabled {
	return
	}
	text := segment.string()
	segment.Enabled = len(strings.ReplaceAll(text, " ", "")) > 0
	if !segment.Enabled {
	segment.env.TemplateCache().RemoveSegmentData(segment.Name())
	return
	}
	segment.writer.SetText(text)
	segment.setCache()
	}

[JanDeDobbeleer]

@lewis-yeung the fix is to add the cache setting by default, I'll add that to the migration script and update the docs. Good catch.

[lewis-yeung]

Confirmed to be fixed in v24.0.9. Thanks.