-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] default to prefer netCDF for all input format types #165
Comments
I think this also eliminates the need to have format specifier inputs in |
Across aerosol, cloud, surface emissivity coefficient LUTs, the only tables that still need to be converted into the NetCDF format are MW water emissivities. Something to be discussed: given the incoming plan for surface module upgrades, and the FASTEM algorithm/structure of these tables, I'd recommend using the existing hardcoded parameterization directly without converting them into the NetCDF format. |
Currently, In various
IO
routines, filenames of the various coefficient files are constructed based onSENSOR_ID
and*_Format
choice between'binary'
and'netCDF'
, wherein it selects the extension appropriate to the*_Format
variable.binary
is presently the default format. The default format or user-defined format occurs inCRTM_Init
. If it fails to find the specified input format file (e.g.,SpcCoeff_Format='binary'
would look for SENSOR_ID//".SpcCoeff.bin"), it doesn't attempt to look for a netCDF file as a backup.However, as we transition to netCDF only inputs, we're running into a situation where we want to prefer netCDF files first, but not fail if it doesn't exist.
This "check" should occur in the IO routines of the various input filetypes, where we start with the default (
netCDF
), then if it fails, try to find the binary file, if that fails, report an error. If it fails to find the netCDF file, but finds the binary as the fallback, this should be reported to the user as a warning. I don't think this should be an over-engineered solution, since ultimately our goal is to completely eliminate the need for binary format files.We'll aim for CRTM v3.2 for this.
The text was updated successfully, but these errors were encountered: