Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TX balancing ignores assets in collateral inputs #754

Closed
Fell-x27 opened this issue May 10, 2024 · 10 comments · Fixed by #936
Closed

TX balancing ignores assets in collateral inputs #754

Fell-x27 opened this issue May 10, 2024 · 10 comments · Fixed by #936

Comments

@Fell-x27
Copy link

Description

If you use a "transaction build" command and do not specify collateral size and output, it tries to build a change automatically.
But if input has a native asset onboard, balancer ignores it and we get an error "CollateralContainsNonADA".

But if we set explicit collateral out with assets and collateral sum manually - everything is ok.

Here is a tx you can't balance automatically: https://preprod.cardanoscan.io/transaction/f8dfe48eb5314d5a582e5fbeb1a07cbb4606ce3c07527d83cdb2d2c5f23e2e9a

Steps to Reproduce

  1. Build a tx with collateral inputs contained some native assets;
  2. Do not set collateral change, let auto-balancer do its job;
  3. Try to submit;
  4. ...
  5. CollateralContainsNonADA :(

Additional Context

LinuxMint 21
cardano-cli 8.20.3.0 - linux-x86_64 - ghc-8.10
git rev 424983fa186786397f5a99539f51710abf62c37b

Possible Solution

Tx balancer have to move all assets from collateral to change. Just move without any calculations :)

@carbolymer
Copy link
Contributor

Do you observe the same behaviour with latest cardano-cli 8.23.1.0? You'd have to use this node version https://github.com/IntersectMBO/cardano-node/releases/tag/8.11.0-pre (to be released soon) - note that's not a mainnet version.

@Fell-x27
Copy link
Author

Didn't test it.

@carbolymer
Copy link
Contributor

8.11.0-pre is released, so you can find binaries under that tag. Let me know if the issue still persists.

@Fell-x27
Copy link
Author

Let me know if the issue still persists.

It is :(

@carbolymer carbolymer self-assigned this May 27, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as abuse.

@carbolymer
Copy link
Contributor

This comment was marked as off-topic.

@github-actions github-actions bot added the Stale label Oct 10, 2024
@dmitrystas
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

We don't like you, Bot. Go away and never come back :)

@github-actions github-actions bot removed the Stale label Oct 11, 2024
@carbolymer carbolymer linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants