Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator Prefixes should use different string helpers #1067

Open
billysmithers opened this issue Mar 3, 2023 · 1 comment
Open

Generator Prefixes should use different string helpers #1067

billysmithers opened this issue Mar 3, 2023 · 1 comment

Comments

@billysmithers
Copy link
Contributor

billysmithers commented Mar 3, 2023 •
edited
Loading

The GeneratorPrefixes class for merging namespace prefix is using Str::title it should be Str::studly.

The route prefix for merging is using Str::camel, IMHO it should be Str::kebab - I would expect semantic URLs to be in kebab case not in camel case.

The view prefix for merging is using Str::snake it should be Str::kebab in line with Laravel convention I would expect these to be in kebab case also.

I'm happy to submit a PR as I have written a proof of concept to verify the changes do as would be expected.
@billysmithers billysmithers mentioned this issue Mar 3, 2023
Open
@billysmithers
Copy link
Contributor Author

PR here - #1070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billysmithers