Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5+ changes interface #22

Open
pelshen opened this issue Dec 11, 2020 · 1 comment
Open

v5+ changes interface #22

pelshen opened this issue Dec 11, 2020 · 1 comment

Comments

@pelshen
Copy link

pelshen commented Dec 11, 2020

Hi there,

I'm upgrading an older application from Angular 4. In the upgrade from 5 to 6 I needed to upgrade RxJS. angular2-redux makes this change in v5, but I'm finding that this breaks every use of the store.select function in the application. Higher versions don't fix this. It seems that when you pass function in as the keyOrSelector, when it it called you actually get the store object, not the state. Screenshot of dev tools showing this below.

angular2-redux

Your angular2-redux-example still uses v4 but as far as I can tell you are using selects there the same way we are. I'm surprised this hasn't been a reported issue before, but can't see that I'm doing anything wrong. Somehow the change between 4 to 5 to upgrade RxJS to 6 seems to have caused this.

Hope you can help

@pelshen
Copy link
Author

pelshen commented Dec 15, 2020

So I've this worked this out. In app-store.ts when RxJS was updated, Observable.from(store) was changed to of(store), rather than to from(store) which has changed how this works. If I change it to from(store), everything works as before. Is this likely to be changed? Otherwise I think I will have to fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant