Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proved that L/K is normal #160

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Proved that L/K is normal #160

merged 3 commits into from
Oct 10, 2024

Conversation

4hma4d
Copy link
Contributor

@4hma4d 4hma4d commented Oct 4, 2024 •
edited
Loading

Proved normal in FrobeniusRiou.lean
Fixes #147

@4hma4d 4hma4d mentioned this pull request Oct 4, 2024
Closed
Ruben-VandeVelde
Ruben-VandeVelde reviewed Oct 6, 2024
View reviewed changes
Copy link
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Some suggestions

FLT/MathlibExperiments/FrobeniusRiou.lean Outdated Show resolved Hide resolved
FLT/MathlibExperiments/FrobeniusRiou.lean Outdated Show resolved Hide resolved
FLT/MathlibExperiments/FrobeniusRiou.lean Outdated Show resolved Hide resolved
FLT/MathlibExperiments/FrobeniusRiou.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde
Copy link
Contributor

And please put "Fixes #147" in the summary

@4hma4d @Ruben-VandeVelde
Apply suggestions from code review
0875b28 
Co-authored-by: Ruben Van de Velde <[email protected]>
@4hma4d
Copy link
Contributor Author

4hma4d commented Oct 6, 2024

Nice job! Some suggestions

Thanks!

@kbuzzard kbuzzard merged commit 936964a into ImperialCollegeLondon:main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FROBENIUS: The residue field extension L/K is normal
3 participants
@4hma4d @Ruben-VandeVelde @kbuzzard