Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pattern control on String, Filename, Path types #214

Open
mborne opened this issue Feb 23, 2021 · 3 comments
Open

Apply pattern control on String, Filename, Path types #214

mborne opened this issue Feb 23, 2021 · 3 comments
Assignees
Milestone

Comments

@mborne
Copy link
Collaborator

mborne commented Feb 23, 2021

Currently, "pattern" control is applied only on String. It should be applied at least to String, Filename and Path types.

Meanwhile, the validator will have to deal with values containing fragments such as "a-file.pdf#page=12" and pattern corresponding to "a-file.pdf".

=> 4.1 as it may lead to unexpected behavior

@mborne mborne self-assigned this Feb 23, 2021
@mborne mborne added the bug label Feb 23, 2021
@mborne mborne modified the milestones: 4.0, 4.1 Feb 23, 2021
@mborne mborne added enhancement and removed bug labels Feb 24, 2021
@mborne mborne modified the milestones: 4.1, 4.x Jun 21, 2021
@pedrogeo
Copy link

pedrogeo commented Aug 10, 2021

Hi,

Since the last version on production of the validator (4.2.15), the rules to verify the paths in the URLREG or URLFIC attributes seems to have changed. Previously, it was possible to write relative paths like ..\Pieces_ecrites\3_Reglement\99999_reglement_20210810.pdf but it's no more possible now. An error with "INVALID_ATTRIBUTE_FORMAT" is detected.

Could you confirme to me if this is a rule change (only absolute paths are valid like https://serveur/99999_reglement_20210810.pdf or if this is a bug ?

Pierre

@mborne
Copy link
Collaborator Author

mborne commented Aug 18, 2021

Hello,

URLREG and URLFIC have been typed as "Url" as it is specified as "Hyperlien" in CNIG standard ( http://cnig.gouv.fr/wp-content/uploads/2019/11/191115_Standard_CNIG_PLU.pdf#page=21&zoom=auto,-260,594 )

A complete URL is expected for URLREG and URLFIC and ..\Pieces_ecrites\3_Reglement\99999_reglement_20210810.pdf should not have been accepted by the past.

As I understand the CNIG standard, NOMFIC and NOMREG allows to specify the name of the file when a complete URL is not available. So, supporting a kind of relative path for URLREG and URLFIC would be useless. Please, use contact form on GpU ( https://www.geoportail-urbanisme.gouv.fr/contact/ ) if you think that it is an error.

Mickaël

PS : This issue is relative to the ability to apply regexp/pattern controls on URL (GpU not concerned)

@pedrogeo
Copy link

pedrogeo commented Sep 6, 2021

Hi,

Thanks for your feedback.

Pierre

@mborne mborne removed this from the 4.x milestone Nov 13, 2022
@mborne mborne added this to the 5.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants