Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example activity XML includes some fixable validation issues #768

Open
stevieflow opened this issue Feb 12, 2024 · 0 comments
Open

Example activity XML includes some fixable validation issues #768

stevieflow opened this issue Feb 12, 2024 · 0 comments
Assignees

Comments

@stevieflow
Copy link
Contributor

Testing https://raw.githubusercontent.com/IATI/IATI-Extra-Documentation/version-2.03/en/activity-standard/activity-standard-example-annotated.xml in the IATI validator

Results:
https://validator.iatistandard.org/report/aad1a0ef-9a8c-4bfe-84f3-00374bd2446a/?isTestFile=true

Category Severity ID Message Location where rule was broken
Participating organisations error 9.40.1 The CRS channel code is invalid. "000000" is not a valid value for attribute @crs-channel-code, in element
Financial error 9.86.1 The recipient region code is invalid. "616" is not a valid value for attribute @code, in element and linked @vocabulary = 1
Financial error 3.6.2 Recipient countries or regions must only be declared at activity level OR for all transactions. For /iati-activities/iati-activity/recipient-country = '' at line: 105, column: 3 and /iati-activities/iati-activity/recipient-country = '' at line: 106, column: 3 and /iati-activities/iati-activity/recipient-region = '' at line: 110, column: 3 and /iati-activities/iati-activity/recipient-region = '' at line: 111, column: 3 and /iati-activities/iati-activity/transaction/recipient-country = '' at line: 280, column: 4 and /iati-activities/iati-activity/transaction/recipient-region = '' at line: 281, column: 4
Identification warning 1.14.8 The reporting organisation id must start with an approved agency code. For /iati-activities/iati-activity/reporting-org/@ref = 'AA-AAA-123456789' at line: 14, column: 22
Geopolitical information error 3.4.2 Percentage values for recipient countries or regions, must add up to 100%. The sum is 75 for recipient-region, recipient-country in vocabulary 1,
Geopolitical information error 3.4.2 Percentage values for recipient countries or regions, must add up to 100%. The sum is 75 for recipient-region, recipient-country in vocabulary 99,
Basic activity information warning 102.1.1 When a non OECD DAC sector vocabulary is used, sector vocabulary 1 - OECD DAC should also be used. For /iati-activities/iati-activity/sector[not(@vocabulary='')] = '' at line: 161, column: 3 and /iati-activities/iati-activity/sector[not(@vocabulary='')] = '' at line: 162, column: 3 and /iati-activities/iati-activity/sector[not(@vocabulary='')] = ' A description of the sector ' at line: 163, column: 3 and /iati-activities/iati-activity/sector[not(@vocabulary='1')] = '' at line: 161, column: 3 and /iati-activities/iati-activity/sector[not(@vocabulary='1')] = '' at line: 162, column: 3 and /iati-activities/iati-activity/sector[not(@vocabulary='1')] = ' A description of the sector ' at line: 163, column: 3
Classifications error 6.6.2 Sectors must only be declared at activity level OR for all transactions. For /iati-activities/iati-activity/sector = '' at line: 161, column: 3 and /iati-activities/iati-activity/sector = '' at line: 162, column: 3 and /iati-activities/iati-activity/sector = ' A description of the sector ' at line: 163, column: 3 and /iati-activities/iati-activity/transaction/sector = '' at line: 278, column: 4
Classifications error 6.13.1 When using a reporting organisation policy marker code (vocabulary 99), it must include a narrative. For at line: 205, column: 3
Performance error 8.11.1 A reference code must only be declared at result OR result indicator level. For /iati-activities/iati-activity/result/indicator/reference[1] = '' at line: 366, column: 6 and /iati-activities/iati-activity/result/indicator/../reference[1] = '' at line: 345, column: 4

Some of these can easily be fix with an update for the code value used in the example XML:

Category Severity ID Message Suggested fix
Participating organisations error 9.40.1 The CRS channel code is invalid. Change code to actual CRS Channel code – eg 10000
Financial error 9.86.1 The recipient region code is invalid. Change code to actual region code – eg 298
Classifications error 6.13.1 When using a reporting organisation policy marker code (vocabulary 99), it must include a narrative. Add to vocab 99 policy marker

That should then isolate some issues where the example XML is trying to model conditional aspects of the schema - which can be looked at separately

@Bjwebb what do you think? I can easily make these changes and push a PR for the updated XML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants