Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Location.hash or window.history.pushState instead of current filtering #15

Open
mostaphaRoudsari opened this issue Oct 8, 2015 · 1 comment
Open

Use Location.hash or window.history.pushState instead of current filtering #15

mostaphaRoudsari opened this issue Oct 8, 2015 · 1 comment
Assignees
@mostaphaRoudsari
Labels
enhancement
Milestone
Patreon goal impr...

Comments

@mostaphaRoudsari
Copy link
Member

Which should be updated by change of the slider image. In that way people can share the page referring to a specific image. It's not possible right now
@mostaphaRoudsari mostaphaRoudsari changed the title uri should include slide number Use Location.hash or window.history.pushState instead of current filtering Oct 24, 2015
@mostaphaRoudsari mostaphaRoudsari self-assigned this Oct 24, 2015
@mostaphaRoudsari mostaphaRoudsari mentioned this issue Oct 27, 2015
Closed
mostaphaRoudsari added a commit that referenced this issue Jan 7, 2016
@mostaphaRoudsari
Added pushState and replaceState
b8e6feb 
Now the url contain slide number as well as zooming and offset data so
you make sure the other person will see the same as you when they open
the page. Addressed #15
@mostaphaRoudsari
Copy link
Member Author

I added slide number and also zoom and offset to the url. Now once you share the url the user will see the same image with the same zoom on their screen. It will be very useful to send the user to the right place. For example follow this link to see the new Therm component that @chriswmackey has developed for Honeybee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostaphaRoudsari mostaphaRoudsari

Labels
enhancement
Projects
None yet
Milestone
Patreon goal improvements
Development

No branches or pull requests
1 participant
@mostaphaRoudsari