Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMIWrapperQ should support port names #2244

Open
robbr48 opened this issue Oct 14, 2024 · 0 comments · May be fixed by #2247
Open

FMIWrapperQ should support port names #2244

robbr48 opened this issue Oct 14, 2024 · 0 comments · May be fixed by #2247
Assignees
Labels
import/export:fmi FMI import/export or functionality
Milestone

Comments

@robbr48
Copy link
Contributor

robbr48 commented Oct 14, 2024

Is your improvement request related to a problem? Please describe.
Ports are named P1, P2, P3 ... depending on their order in the portspecs parameter. This can be confusing for e.g. hydraulic valves, where they are expected to be called "PP", "PT", "PA" and so on.

Describe the solution you'd like
Allow user to choose a port name in the portspecs parameter, e.g. "NodeHydraulic,PP,x,y,z...". This must be backwards compatible with the current solution, i.e. work even if no port name is provided.

@robbr48 robbr48 added the import/export:fmi FMI import/export or functionality label Oct 14, 2024
@robbr48 robbr48 added this to the 2.23.0 milestone Oct 14, 2024
@robbr48 robbr48 self-assigned this Oct 14, 2024
@robbr48 robbr48 linked a pull request Oct 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import/export:fmi FMI import/export or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant