Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost 1.84 #159169

Merged
merged 152 commits into from
Jan 25, 2024
Merged

boost 1.84 #159169

merged 152 commits into from
Jan 25, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jan 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the long build Set a long timeout for formula testing label Jan 6, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 6, 2024
@SMillerDev
Copy link
Member

Shall I close #158705 then?

@iMichka
Copy link
Member Author

iMichka commented Jan 6, 2024

Sorry, I missed #158705, my bad :(. Your's did not have the "long build" label, and as I did not see boost 1.84 in the long builds, I did not check for it in the other pull requests. I can push my changes to your pull request if you want, or we can close your's, as you wish.

@iMichka iMichka added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-linux-self-hosted Build on Linux self-hosted runner labels Jan 7, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 8, 2024
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 11, 2024
@chenrui333 chenrui333 added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Jan 12, 2024
@Porkepix
Copy link
Contributor

Is it normal if every builds fails that it still tests the dependents?
I guess no long build conflict can be removed anyway, to allow for spdlog when this one will be run.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 12, 2024
@chenrui333 chenrui333 removed the no long build conflict Do not allow merging other pull requests when files conflict with this one label Jan 13, 2024
@chenrui333 chenrui333 mentioned this pull request Jan 13, 2024
@SMillerDev
Copy link
Member

The python failure makes no sense since it seems to be using C++14 on our side.

@iMichka
Copy link
Member Author

iMichka commented Jan 18, 2024

I have a bunch of patches ready, will push as soon as I made significant progress, as not to pollute the long build queue too early.

@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 21, 2024
@iMichka iMichka force-pushed the boost1.84 branch 2 times, most recently from b815cf4 to 69bbe2b Compare January 21, 2024 21:09
@chenrui333 chenrui333 added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Jan 21, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 22, 2024
@carlocab carlocab removed the no long build conflict Do not allow merging other pull requests when files conflict with this one label Jan 23, 2024
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 24, 2024
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 25, 2024
Merged via the queue into Homebrew:master with commit f216a65 Jan 25, 2024
12 checks passed
@iMichka iMichka deleted the boost1.84 branch January 26, 2024 22:24
@iMichka
Copy link
Member Author

iMichka commented Jan 26, 2024

@iMichka Doesn't the build failing for fastnetmon on 12-x86_64 and 13-x86_64 not only the dependencies testing means it'll need some bottle rebuild after merge, though?

It's all good, no bottles were lost. Only dspdfviewer which I have added in #161046

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants