Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can FlashFFTConv be used for Conv2d on PyTorch? #22

Open
5thGenDev opened this issue Feb 21, 2024 · 6 comments
Open

Can FlashFFTConv be used for Conv2d on PyTorch? #22

5thGenDev opened this issue Feb 21, 2024 · 6 comments

Comments

@5thGenDev
Copy link

No description provided.

@DanFu09
Copy link
Contributor

DanFu09 commented Feb 26, 2024

Not yet, but it's something we're very interested in looking into soon.

To help us target better - what models do you want to use it for? Are they depthwise or grouped convolutions, and what are the filter sizes?

@5thGenDev
Copy link
Author

5thGenDev commented Feb 28, 2024

Just normal Conv3x3-conv and I noticed the paper didn't say anything about really small filter size. I plan to use it in U-Net Diffusion

@5thGenDev
Copy link
Author

Not yet, but it's something we're very interested in looking into soon.

To help us target better - what models do you want to use it for? Are they depthwise or grouped convolutions, and what are the filter sizes?

Hello, will normal conv3x3 and (conv3x3 where group size = 4) be compatible with FlashFFTConv?

@DanFu09
Copy link
Contributor

DanFu09 commented Jun 11, 2024

The 3x3 wouldn't be a great use case right now - we specialize for really long filters (size on the order of the input image).

@nianliu26
Copy link

The 3x3 wouldn't be a great use case right now - we specialize for really long filters (size on the order of the input image).

There is not any Conv2d application? So, I must encode the data to tokens like attention if I want to use it on CV?

@DanFu09
Copy link
Contributor

DanFu09 commented Sep 26, 2024

That's correct, we don't have a Conv2D implemented right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants