-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php] return type declarations #11758
Labels
platform-php
Everything related to PHP
Comments
So the problem is that the compiler doesn't emit the |
Yes. You'd subclass framework classes and override some methods so it has to obey the covariance and contravariance rules. Of course it's not just Void, for example you'd also override buildRules():
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I have this extern for a CakePHP class
And this subclass
Then this php is emitted
But initialize() has a return type declaration from CakePHP 4 onward so this doesn't work too well:
It would be nice if extern methods could be annotated as having a return type so the compiler would emit overrides with the correct type.
The text was updated successfully, but these errors were encountered: