Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save data can get completely overridden if unserialization fails #3269

Open
EliteMasterEric opened this issue Oct 17, 2024 · 1 comment · May be fixed by #3270
Open

Save data can get completely overridden if unserialization fails #3269

EliteMasterEric opened this issue Oct 17, 2024 · 1 comment · May be fixed by #3270

Comments

@EliteMasterEric
Copy link
Contributor

flixel/flixel/util/FlxSave.hx

Lines 459 to 466 in f5087ea

try
{
final unserializer = new haxe.Unserializer(encodedData);
final resolver = { resolveEnum: Type.resolveEnum, resolveClass: SharedObject.__resolveClass };
unserializer.setResolver(cast resolver);
sharedObject.data = unserializer.unserialize();
}
catch (e:Dynamic) {}

Relevant issue: FunkinCrew/Funkin#3679

The v0.5.2 update for Funkin' introduced new properties to the user's save data. One of these properties was an Enum value, and as a result older versions of the game will fail to parse the save data.

In the case that save data fails to parse at this stage, sharedObject.data will remain null, and the game will act as though it is a fresh installation with no save data, and write to the save data file.

Without modifying this behavior, there is no chance for backup or recovery of the save data.
@EliteMasterEric EliteMasterEric mentioned this issue Oct 17, 2024
Open
2 tasks
@EliteMasterEric
Copy link
Contributor Author

EliteMasterEric commented Oct 18, 2024 •
edited
Loading

Looking at the code for FlxSave more, there is an FlxSaveStatus.ERROR but this is not used if there is an unserialization error.

EDIT: It also ignores the haxe.Unserializer.DEFAULT_RESOLVER! I was trying to override that to fix behavior myself but apparently that's not an option!

@EliteMasterEric EliteMasterEric linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement error handling for save data unserialization. FunkinCrew/flixel
1 participant
@EliteMasterEric