Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCE.Shared has grown too complex for a single NPM package #413

Open
BinToss opened this issue Aug 22, 2024 · 0 comments
Open

HCE.Shared has grown too complex for a single NPM package #413

BinToss opened this issue Aug 22, 2024 · 0 comments

Comments

@BinToss
Copy link
Member

BinToss commented Aug 22, 2024

This should be broken up into multiple packages.
The package @halospv3/hce.shared-config was intended to be a single config with some non-default plugins included and the NPM plugin excluded.

Although the base config has remained relatively unchanged, the package now includes far more than just a config with some bundled plugins.

Additionally, the ongoing refactors for @halospv3/hce.shared-config@v3 have made it apparent some operations should be done (or would be accomplished more easily) via dedicated Semantic Release plugins instead of via strings passed to @semantic-release/exec.

Proposal: Milestone 4

Milestone 3 (@halospv3/hce.shared-config) dumps CJS compatibility and massively refactors the dotnet components.

Milestone 4 will produce a "full" package in addition to packages for...

  • the CommitLint config
  • the Semantic Release base config
  • the Semantic Release dotnet config, modules, msbuild files, and GitHub Actions workflows
  • the (planned) Semantic Release CXX modules, msbuild files, and GitHub Actions workflows
  • ...additional packages for other shareable configs

Up for debate:

  • Should a shared dependencies package still be maintained so NPM updates can be handled more-or-less centrally? This may lead to node_module bloat in dependent projects.
@BinToss BinToss added this to the 4 - Dissolution milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant