Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xero refresh token not retained #2

Open
jhogendorn opened this issue Aug 10, 2023 · 0 comments
Open

Xero refresh token not retained #2

jhogendorn opened this issue Aug 10, 2023 · 0 comments

Comments

@jhogendorn
Copy link
Contributor

The tap-xero does not properly store the refresh token, so when it runs each time the token is invalidated and you have to have a human do the init auth flow again.

https://meltano.slack.com/archives/C01TCRBBJD7/p1691310724043439

Suggested fix is to alter the tap to use bookmarks. examples:

Read: https://github.com/s7clarke10/pipelinewise-tap-mssql/blob/f7a0bf18c01d24aa55ce5fbc8b3bc7ee9c928fc7/tap_mssql/sync_strategies/log_based.py#L289
Write: https://github.com/s7clarke10/pipelinewise-tap-mssql/blob/f7a0bf18c01d24aa55ce5fbc8b3bc7ee9c928fc7/tap_mssql/sync_strategies/log_based.py#L389C93-L389C93

If it can track whatever the last refresh token it was given is this will work.

Relevant lines in tap-xero:

Read: https://github.com/singer-io/tap-xero/blob/16dd78c8ee6c77245d45876fc0f6d9e4a41a387d/tap_xero/client.py#L198
Write: https://github.com/singer-io/tap-xero/blob/16dd78c8ee6c77245d45876fc0f6d9e4a41a387d/tap_xero/client.py#L208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant