Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move network import type from NodeInput::Network to NodeNetwork in order to enable automatic Into node insertion #2042

Open
adamgerhant opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
Architecture Involves architecture or engineering work or discussion Graphene Involves the node graph system/engine used by Graphite

Comments

@adamgerhant
Copy link
Collaborator

Instead of annotating type for each NodeInput::network usage, the types should be annotated in a single vec for every import.
For example we do something like

pub fn node(input1){
  subnode(input1: String)
  subnode(input1: String)
  etc
}

rather than

pub fn node(input1: String){
  subnode(input1)
  subnode(input1)
  etc
}

Technically I dont think we even need to annotate the parameters, since their types can be resolved at compile time. However, this system would be useful/necessary for automatic into node insertion (#1890), as well as displaying what types can be connected to a node when hovering over the input.

Discussions here:
https://discord.com/channels/731730685944922173/731738914812854303/1253116397370998794
https://discord.com/channels/731730685944922173/860830913390575646/1271586374314885201
https://discord.com/channels/731730685944922173/860830913390575646/1271605307771981987

@adamgerhant adamgerhant added Architecture Involves architecture or engineering work or discussion Graphene Involves the node graph system/engine used by Graphite labels Oct 16, 2024
@0HyperCube 0HyperCube self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Involves architecture or engineering work or discussion Graphene Involves the node graph system/engine used by Graphite
Projects
Status: Short-Term
Development

No branches or pull requests

3 participants
@0HyperCube @adamgerhant and others