Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Issue Dashboard #2413

Closed
Huddie opened this issue Nov 8, 2018 · 32 comments
Closed

Issue Dashboard #2413

Huddie opened this issue Nov 8, 2018 · 32 comments
Assignees
Labels
👍 feature approved Features approved for implementation

Comments

@Huddie
Copy link
Collaborator

Huddie commented Nov 8, 2018

Issue dashboard is a nice way to keep track of the issues you're assigned/created.
This differs from notifications since those appear only when something occurs in the thread.

Currently, you may bookmark issues you're assigned to in order to keep track of them.

What's happening in the gif:

  • Open issue dashboard, nothing shows up (I'm not assigned to any issues)
  • I think went and assigned myself to a task
  • Refreshed the view and saw the issue
@rnystrom
Copy link
Member

rnystrom commented Nov 8, 2018

Sorry I’m a little confused. What’s happening here? Is this a new feature proposal?

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 8, 2018

Ya. It’s Githubs Issue Dashboard. I think it can be nicely expanded at some point to have a segment controller that allows switching between:

  • all issues your assigned to
  • all issues you’ve created
  • all issues your mentioned in
  • all issues you’ve subscribed to

Currently it’s set to the default (only those your assigned to)

Adding the others will match Github better.

Sent with GitHawk

@Huddie Huddie changed the title Issue Dashboard to GitHawk Issue Dashboard Nov 8, 2018
@rnystrom
Copy link
Member

rnystrom commented Nov 8, 2018

Lol I didn’t know this was a thing! We used to have a seg control but cycling through unread and everything was weird. Maybe we can give it another try.

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 8, 2018

Oh ya! I just saw it on github recently and thought it would be nice if GitHawk could get it.

Inbox is nice cause it tells you something changed, but you can’t keep track of the issues your supposed to be working on or you subscribed to.

I think subscribed and assigned are the 2 most interesting ones.

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

#1265 would closed by this

Sent with GitHawk

@Huddie Huddie mentioned this issue Nov 27, 2018
5 tasks
@rnystrom
Copy link
Member

Revisiting after seeing this on the Twitter thread. Here's an idea for the inbox redesign (#2497):

  • Keep inbox list as-is
  • Title view is the same dropdown control we use in issues, etc
  • Tap the control to show a ContextMenu with a sectioned list:
    • "Me"
      • Inbox
      • Mentioned
      • Created
      • Assigned
    • "Repos" (should be a list of subbed/watched repos, NOT the lazy-filtering we do today)
      • GitHawk
      • IGListKit
      • etc
  • Checkmark on w/e you have selected
  • Tap a thing to dismiss the menu and update the inbox (don't push a vc)
  • (stretch) Put a settings menu that lets you change the default inbox to one of the "Me" boxes

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 28, 2018

Love it.

So we don’t pull all issues then filter. We make specific calls getting the appropriate issues each time the user updates?

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 28, 2018

The issue Dashboard above uses https://developer.github.com/v3/issues/#list-issues with the filtering parameter. That’s what we’re going for ya?

Sent with GitHawk

@rnystrom
Copy link
Member

@Huddie ya exactly. You can toggle what "mode" your inbox is in: one of the viewer-filters, a specific repo, or the master list.

@ijm8710
Copy link

ijm8710 commented Nov 28, 2018

Stellar!

  1. I think this would be a great time to coincide incorporating an open/closed/all toggle. It would have relevance here and also be a great port on the search tab as well; the current implementation doesn’t feel as natural.
  2. I could see value to an additional “me” option for participating (commenter:username)
  3. Obviously this would be a growing project, but do you eventually see this implementing the per-repo inbox logic or is this an alternative to that?

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 28, 2018

@rnystrom cool that’s how I was thinking about it with the Issue Dashboard. I think it makes a lot of sense and putting in a drop down on the Nav Bar keeps the style consistent with other parts of the app.

Sent with GitHawk

@SD10
Copy link
Member

SD10 commented Nov 28, 2018

I'm pretty inactive in the OS community right now but def lurking this thread. I can only offer a unique perspective that I actually haven't used GitHawk for maybe a month now -- through no fault of GitHawk. It's GitHub notifications that just aren't scaling for my needs.

I can +1 the idea of a context menu for filters.

  • Inbox
  • Mentioned
  • Created
  • Assigned

Additionally, if there's a way to filter by merged PRs that would be a huge help too. For context, I often have to subscribe to a codebase just to be aware of people merging things without my review.

With some of these filters, I think GitHawk could help me regain control of notifications because I wouldn't open the app to a giant inbox sorted by event date.

Thanks for all the awesome work you guys have done 💯

@rnystrom
Copy link
Member

  1. Is for repo issue/PRs, not inbox
  2. Is this not captured in the other filters?
  3. Alternative. Per-repo view will have way too complex and confusing of UX because of API paging. Until a new and improved API (maybe GraphQL) launches, it can’t happen.

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Nov 28, 2018

  1. Originally, yes. But isn’t there relevance (i.e) to viewing created threads and filtering them by open vs closed? Same for the inbox or really any of the “me” options.
  2. No. Inbox clutters-in any watched sub so you can’t narrow solely on threads you had activity in specifically. Created is only posts you actually authored. Mentioned is only posts you were tagged on. For example, I’ve participated in this thread, it’s one I truly care about, but it would only fall in the inbox category and none of the others for me, but again I’m trying to subset it even more than how current inbox does.
  3. Understood about the complexity. I was curious your thoughts on slightly enhancing the current setup where each repo can be selected separate but for both unread and all views. Currently I think you can only menu select a specific-repo for the all view. But is there any way to filter the unread inbox so that it repopulates for just one selected repo or does that pose the same pagination complication?

@rnystrom rnystrom added 👍 feature approved Features approved for implementation and removed 🆕 feature request A feature being requested to be added, not yet approved labels Dec 2, 2018
@rnystrom rnystrom self-assigned this Dec 2, 2018
@rnystrom
Copy link
Member

rnystrom commented Dec 3, 2018

Started hacking on this today. Made some ground, but its a lot more complex than it seems. The API for mention/create/assign/etc issues is not a notification endpoint. So there's no "read" or "unread" status. It's a V3 API (there is a GraphQL API as well).

This means we have to create a totally new request+display pipeline for it (section controllers, cells). Not impossible, just changes the UX quite a bit.

simulator screen shot - iphone xs - 2018-12-02 at 20 35 04

simulator screen shot - iphone xs - 2018-12-02 at 20 36 06

@rnystrom
Copy link
Member

rnystrom commented Dec 3, 2018

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 3, 2018

Ya, I was using V3 issues. This looks amazing.

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

Curious, what’s the difference between subscribed and inbox? This does look awesome though

@rnystrom
Copy link
Member

rnystrom commented Dec 3, 2018

That’s a good question, I’m not totally sure. We might be able to drop that one tbh.

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

I would be surprised if they didn’t always match up conceptually 1:1

For consistency with GitHub it might even make sense to do unread notifications (or “unread” if too long) with a bell icon. Of the two you have, I think subscribed and it’s icon is more visually appealing than inbox though.

Did my comment make sense that it would be nice to have the participating view that can be found on GitHub. None of the views you have WIP encompass this

@j-f1
Copy link

j-f1 commented Dec 3, 2018

How about having the repo filter as a separate button so people can select a combination of e. g. mentioned and a specific repo?

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 3, 2018

Subscribed: All thread your subscribed to
Inbox: Notifications (could be a thread your subscribed to, watching, mentioned in)

Subscribed would show all those your subscribed to regardless if there was a recent notification/activity or not.
Inbox will show only those threads which your subscribed to (or watching <~ another difference) and have current activity (there was a notification)

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

@Huddie but for #2482, if you watch a repo/thread that you may have never been mentioned or commented in, wouldn’t that still show as having an active subscription? Meaning for some reason I feel subscribed picks up watching...at least on GitHub, no?

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 3, 2018

Watching means you watch the repo.
Subscription means you subscribed to a thread.

If you look at a specific thread it could say your getting notification because you’re watching this repo. So it may show you have an active subscription on GitHub but I’m pretty sure the reason matters. I think you can subscribe to a thread your watching and then if you stop watching the repo you’ll still be subscribed. But you’d have to check that.

Regardless that’s not the difference between notifications and subscriptions.

The difference is that one denotes activity in such thread, the other is just showing what you are subscribed to. Whether or not any activity recently occurred that warranted a notification.

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

@Huddie let me try phrasing it a different way with a simple question. Since you’re talking about the difference between inbox and subscriptions, I know we have “notifications” on native GitHub which can be perused unread/read. Is there another complimenting native list view on GitHub that has a listing for us to essentially mimic the contrast you mention here?

Basically something to repro the two unique list-sets in action.

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 3, 2018

Issue Dashboard ? All tabs make up most of the issues your subscribed to

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

Yes and I see the issue dashboard has assigned, created, mentioned, but in the same way that unread notifications hits on how either inbox or subscribed works, what aggregate view on issue dashboard hits on the other?

I’m basically asking is there a list-set in it that is different from anything else we see implemented in Ryan’s wip; since you’re saying they’re different I just expect on GitHub to see these two opposing lists there as well

Not saying you’re wrong, I just don’t see it natively, perhaps it’s something that isn’t quite there natively yet

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 3, 2018

If your asking if there are threads subscribed to that you didn’t create, mentioned in or assigned. The answer is yes. Whether or not GitHub has this list visible I’m not sure.

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 3, 2018

My whole point is that, at least I, think it’d have more value to have a participated list and a notification list (read vs all, which id really see value with a toggle) than having both inbox and subscriptions. And to perhaps have per-repo as a separate button for it as j-fi suggested

@Huddie
Copy link
Collaborator Author

Huddie commented Dec 16, 2018

@rnystrom Why was subscribed dropped?

Sent with GitHawk

@rnystrom
Copy link
Member

Overlap with traditional notifications

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Dec 16, 2018

Excellent work Ryan! I have some comments/requests of course but for a bit I just want to let this soak in and appreciate the awesome work on it since I know you’ve felt a little burnt out and looks like you took a tiny hiatus hopefully to recharge a bit with this hobby! Good job with the dashboard suggestion too @Huddie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
👍 feature approved Features approved for implementation
Projects
None yet
Development

No branches or pull requests

5 participants