-
Notifications
You must be signed in to change notification settings - Fork 385
Issue Dashboard #2413
Comments
Sorry I’m a little confused. What’s happening here? Is this a new feature proposal? Sent with GitHawk |
Ya. It’s Githubs Issue Dashboard. I think it can be nicely expanded at some point to have a segment controller that allows switching between:
Currently it’s set to the default (only those your assigned to) Adding the others will match Github better. Sent with GitHawk |
Lol I didn’t know this was a thing! We used to have a seg control but cycling through unread and everything was weird. Maybe we can give it another try. Sent with GitHawk |
Oh ya! I just saw it on github recently and thought it would be nice if GitHawk could get it. Inbox is nice cause it tells you something changed, but you can’t keep track of the issues your supposed to be working on or you subscribed to. I think subscribed and assigned are the 2 most interesting ones. Sent with GitHawk |
Revisiting after seeing this on the Twitter thread. Here's an idea for the inbox redesign (#2497):
|
Love it. So we don’t pull all issues then filter. We make specific calls getting the appropriate issues each time the user updates? Sent with GitHawk |
The issue Dashboard above uses https://developer.github.com/v3/issues/#list-issues with the filtering parameter. That’s what we’re going for ya? Sent with GitHawk |
@Huddie ya exactly. You can toggle what "mode" your inbox is in: one of the viewer-filters, a specific repo, or the master list. |
Stellar!
|
I'm pretty inactive in the OS community right now but def lurking this thread. I can only offer a unique perspective that I actually haven't used GitHawk for maybe a month now -- through no fault of GitHawk. It's GitHub notifications that just aren't scaling for my needs. I can +1 the idea of a context menu for filters.
Additionally, if there's a way to filter by merged PRs that would be a huge help too. For context, I often have to subscribe to a codebase just to be aware of people merging things without my review. With some of these filters, I think GitHawk could help me regain control of notifications because I wouldn't open the app to a giant inbox sorted by event date. Thanks for all the awesome work you guys have done 💯 |
Sent with GitHawk |
|
Started hacking on this today. Made some ground, but its a lot more complex than it seems. The API for mention/create/assign/etc issues is not a notification endpoint. So there's no "read" or "unread" status. It's a V3 API (there is a GraphQL API as well). This means we have to create a totally new request+display pipeline for it (section controllers, cells). Not impossible, just changes the UX quite a bit. |
Ya, I was using V3 issues. This looks amazing. |
Curious, what’s the difference between subscribed and inbox? This does look awesome though |
That’s a good question, I’m not totally sure. We might be able to drop that one tbh. Sent with GitHawk |
I would be surprised if they didn’t always match up conceptually 1:1 For consistency with GitHub it might even make sense to do unread notifications (or “unread” if too long) with a bell icon. Of the two you have, I think subscribed and it’s icon is more visually appealing than inbox though. Did my comment make sense that it would be nice to have the participating view that can be found on GitHub. None of the views you have WIP encompass this |
How about having the repo filter as a separate button so people can select a combination of e. g. mentioned and a specific repo? |
Subscribed: All thread your subscribed to Subscribed would show all those your subscribed to regardless if there was a recent notification/activity or not. Sent with GitHawk |
Watching means you watch the repo. If you look at a specific thread it could say your getting notification because you’re watching this repo. So it may show you have an active subscription on GitHub but I’m pretty sure the reason matters. I think you can subscribe to a thread your watching and then if you stop watching the repo you’ll still be subscribed. But you’d have to check that. Regardless that’s not the difference between notifications and subscriptions. The difference is that one denotes activity in such thread, the other is just showing what you are subscribed to. Whether or not any activity recently occurred that warranted a notification. Sent with GitHawk |
@Huddie let me try phrasing it a different way with a simple question. Since you’re talking about the difference between inbox and subscriptions, I know we have “notifications” on native GitHub which can be perused unread/read. Is there another complimenting native list view on GitHub that has a listing for us to essentially mimic the contrast you mention here? Basically something to repro the two unique list-sets in action. |
Issue Dashboard ? All tabs make up most of the issues your subscribed to Sent with GitHawk |
Yes and I see the issue dashboard has assigned, created, mentioned, but in the same way that unread notifications hits on how either inbox or subscribed works, what aggregate view on issue dashboard hits on the other? I’m basically asking is there a list-set in it that is different from anything else we see implemented in Ryan’s wip; since you’re saying they’re different I just expect on GitHub to see these two opposing lists there as well Not saying you’re wrong, I just don’t see it natively, perhaps it’s something that isn’t quite there natively yet |
If your asking if there are threads subscribed to that you didn’t create, mentioned in or assigned. The answer is yes. Whether or not GitHub has this list visible I’m not sure. Sent with GitHawk |
My whole point is that, at least I, think it’d have more value to have a participated list and a notification list (read vs all, which id really see value with a toggle) than having both inbox and subscriptions. And to perhaps have per-repo as a separate button for it as j-fi suggested |
Overlap with traditional notifications Sent with GitHawk |
Excellent work Ryan! I have some comments/requests of course but for a bit I just want to let this soak in and appreciate the awesome work on it since I know you’ve felt a little burnt out and looks like you took a tiny hiatus hopefully to recharge a bit with this hobby! Good job with the dashboard suggestion too @Huddie |
Issue dashboard is a nice way to keep track of the issues you're assigned/created.
This differs from notifications since those appear only when something occurs in the thread.
Currently, you may bookmark issues you're assigned to in order to keep track of them.
What's happening in the gif:
The text was updated successfully, but these errors were encountered: