Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubber will occasionally hang on close compiling android #20

Open
lysine opened this issue Jun 6, 2019 · 4 comments
Open

rubber will occasionally hang on close compiling android #20

lysine opened this issue Jun 6, 2019 · 4 comments

Comments

@lysine
Copy link

lysine commented Jun 6, 2019

rubber.ts line 544 : igor.on('close', async(code) => {

changing this to exit solves the problem.

@shichen85
Copy link
Contributor

Good find, though on Windows, if you monitor the background processes, you will see that the java.exe process is not exited. Not sure if it has any side-effects, so I have been killing it once Igor.exe exits.

@clee2005
Copy link

So can you use Rubber to build iOS and Android exports? I understood it was only for Windows. If so how do you specify the export?

@shichen85
Copy link
Contributor

So can you use Rubber to build iOS and Android exports? I understood it was only for Windows. If so how do you specify the export?

If you look at src/cli.ts, you just need to specify the export-platform option, which includes: "windows" | "mac" | "linux" | "ios" | "android" | "ps4" | "xboxone" | "switch" | "html5"

@StarGardenGames
Copy link

StarGardenGames commented Jun 2, 2021

The above solution worked on my local machine but not my build servers

Here's a different workaround I came up with. It's definitely hacky, but it's sufficient for my use case

--- a/src/cli.ts
+++ b/src/cli.ts
@@ -186,4 +186,14 @@ cli.main(async (args, options) => {
         if (!igorErrors)
             cli.fatal(error.message);
     });
+    function kill(){
+        console.log("EXIT 0");
+        process.exit(0);
+    }
+    build.on("rawStdout", (data: string) => {
+        if(platform == "android" && data.includes("Igor Complete.")){
+            console.log("EXIT 0");
+            setTimeout(kill, 10000);
+        }
+    });
 });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants