Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Account #3273

Open
3 of 5 tasks
sandipndev opened this issue May 17, 2024 · 3 comments · Fixed by #3272 or #3307
Open
3 of 5 tasks

Multi Account #3273

sandipndev opened this issue May 17, 2024 · 3 comments · Fixed by #3272 or #3307
Milestone

Comments

@sandipndev
Copy link
Member

sandipndev commented May 17, 2024

Objectives

  • Migrate token management to enable saving multiple accounts to keystore
  • Switch account UI component inside Account Screen
  • Integrate add account and logouts
  • Extend push notification taps to handle auto switching to target account
  • Display username of account for which a notification has arrived

Summer of Bitcoin project taken up by @Prakhar-Agarwal-byte
Docs

@sandipndev sandipndev added this to the Multi Account milestone May 17, 2024
@nicolasburtey
Copy link
Member

@sandipndev I would recommend to have @Prakhar-Agarwal-byte tackle in the first couple of weeks (2 to 4 weeks maybe?) some papercut items before tackling the multi account issue, because it's a complex one, and getting use to codebase/tests/grpahql layer, etc would probably come handy

@sandipndev
Copy link
Member Author

Now that Prakhar has experience working with various parts of the codebase, I'm helping him accelerate multi account work. Because of the team's focus on other parts of the codebase right now, I will be merging his work to a different multi-account branch. The entire team can review the trail / final multi account branch build when we have realigned ourselves to mobile work.

@sandipndev sandipndev pinned this issue Jun 15, 2024
@sandipndev
Copy link
Member Author

@Prakhar-Agarwal-byte

I think the following UI changes will be needed:

  1. When a user switches their account, at the loading state, the user shouldn't be able to go "back"
  2. When the request is complete and the token has been set, the user should straight be taken one level back to their account page
  3. Question: How are accounts without usernames handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants