-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify FactGenerator/Datalog relation names #42
Labels
Comments
4 tasks
There is some urgency to this task: It's important to do this early in the git history if we're to do it at all. The git history of this project is fairly empty at this point, but someday will encode important choices about how the analysis was constructed. |
Merged
For the sake of posterity, here are the major areas where they disagree, and how I'm approaching them in #45:
|
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #40, the Fact Generator and Datalog code share a list of file/relation names. The Fact Generator refers to relations by
group::rel
, e.g.,variable::name
, whereas that corresponds to the Datalog relationvariable_name
. While there is a clear correspondence betweenvariable::name
andvariable_name
, the relationship doesn't hold in general, e.g. we also havevariable::id
corresponding to justvariable
. Thus,predicates.inc
has lines like:where the first two entries describe the C++ (Fact Generator) name, and the third entry describes the filename/Datalog relation name. We should try to derive the latter from the former for the sake of consistency. This will involve changing a ton of Datalog code to use new relation names.
The text was updated successfully, but these errors were encountered: