Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function clCreateCommandQueue #5

Open
dineiar opened this issue Jul 14, 2024 · 0 comments
Open

Remove deprecated function clCreateCommandQueue #5

dineiar opened this issue Jul 14, 2024 · 0 comments

Comments

@dineiar
Copy link
Member

dineiar commented Jul 14, 2024

The step "Build library" of the GitHub build action that is triggered on every commit outputts the following message (ex.: https://github.com/GMAP/GSParLib/actions/runs/8041704362/job/21961317445):

Compiling and assembling object build/GSPar_OpenCL.o...
g++  -Wall -std=c++14 -O3 -Wno-reorder -I/usr/local/cuda/include -Isrc -c -fPIC -o build/GSPar_OpenCL.o src/GSPar_OpenCL.cpp
src/GSPar_OpenCL.cpp: In member function ‘virtual _cl_command_queue* GSPar::Driver::OpenCL::ExecutionFlow::start()’:
src/GSPar_OpenCL.cpp:165:48: warning: ‘_cl_command_queue* clCreateCommandQueue(cl_context, cl_device_id, cl_command_queue_properties, cl_int*)’ is deprecated [-Wdeprecated-declarations]
  165 |         this->flowObject = clCreateCommandQueue(device->getContext(), device->getBaseDeviceObject(), 0, &status);
      |                            ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/CL/opencl.h:24,
                 from src/GSPar_OpenCL.hpp:8,
                 from src/GSPar_OpenCL.cpp:11:
/usr/include/CL/cl.h:1[9](https://github.com/GMAP/GSParLib/actions/runs/8041704362/job/21961317445#step:7:10)06:1: note: declared here
 [19](https://github.com/GMAP/GSParLib/actions/runs/8041704362/job/21961317445#step:7:20)06 | clCreateCommandQueue(cl_context                     context,
      | ^~~~~~~~~~~~~~~~~~~~

We should remove the deprecated function clCreateCommandQueue. According to jprice on StackOverflow:

The clCreateCommandQueue function was deprecated as of OpenCL 2.0, and replaced with clCreateCommandQueueWithProperties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant