Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove onInit #106

Open
GGAlanSmithee opened this issue Nov 21, 2018 · 0 comments
Open

remove onInit #106

GGAlanSmithee opened this issue Nov 21, 2018 · 0 comments
Assignees
@GGAlanSmithee
Labels
enhancement
Milestone
v 4.0.0

Comments

@GGAlanSmithee
Copy link
Owner

See #90 for background

The EntityManager.onInit makes little sense. When should it be ran? WHen the system is initialized, or when a new entity is created, or at another time? How could it be triggered from the inside of the EntityManager but allow for passing options from the outside?

Initializing an entity is the job of the EntityFactory
@GGAlanSmithee GGAlanSmithee added this to the v 4.0.0 milestone Nov 21, 2018
@GGAlanSmithee GGAlanSmithee self-assigned this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GGAlanSmithee GGAlanSmithee

Labels
enhancement
Projects
None yet
Milestone
v 4.0.0
Development

No branches or pull requests
1 participant
@GGAlanSmithee