From e0106fca5754bc4e675238bb9ee1878184fe7dda Mon Sep 17 00:00:00 2001 From: Rajin Braynard <85237518+FuexFollets@users.noreply.github.com> Date: Sat, 27 Jan 2024 12:48:49 -0500 Subject: [PATCH] Fixed opts.cmake compile flags based on compiler --- cmake/opts.cmake | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/cmake/opts.cmake b/cmake/opts.cmake index 7cdeb61..b1040cf 100644 --- a/cmake/opts.cmake +++ b/cmake/opts.cmake @@ -4,10 +4,15 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON) set(CMAKE_CXX_STANDARD 20) -if(CMAKE_COMPILER_IS_GNUCXX) - message(STATUS "GCC detected, adding compile flags") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -g") -endif() +set(base_flags "-Wall -Wextra -Wpedantic -g") -set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -g -O0") +if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC") + # Remove -Wextra for MSVC + string(REPLACE "-Wextra" "" flags "${base_flags}") +else() + # Use base flags for other compilers + set(flags "${base_flags}") +endif() +# Apply the final flags +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${flags}")