TranslatableCustomEntityRepository->createDatagridQueryBuilder uses non existant parameter

[Schwierig]

The createDatagridQueryBuilder() method in the Pim\Bundle\CustomEntityBundle\Entity\Repository\TranslatableCustomEntityRepository class uses the localeCode parameter which is not set in any of the classes functions. If it is on purpose that the user should specify the parameter when extending, there should be at least a comment somewhere stating that.

[jmleroux]

Bug detected here https://github.com/akeneo-labs/CustomEntityBundle/blob/master/Entity/Repository/TranslatableCustomEntityRepository.php#L26

Thank you for pointing, i will take it in charge

[mmetayer]

Actually, this parameter is automatically appended to the queryBuilder by Pim\Bundle\DataGridBundle\EventListener\AddLocaleCodeToGridListener, see here.
We should definitely add a comment that it must be kept when overriding the Pim\Bundle\CustomEntityBundle\Entity\Repository\TranslatableCustomEntityRepository