Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of PKTIO_READ_BUFFER_SIZE #169

Closed
KeitaKashima opened this issue May 21, 2024 · 4 comments
Closed

Configuration of PKTIO_READ_BUFFER_SIZE #169

KeitaKashima opened this issue May 21, 2024 · 4 comments
Assignees

Comments

@KeitaKashima
Copy link

Hi, I am using this cellular interface lib, but I faced an issue of below.

The log message showed No empty space from comm if to handle incoming data, reset all parameter for next incoming data.

image

After I changed PKTIO_READ_BUFFER_SIZE of definition value to 4096, it was solved.

#define PKTIO_READ_BUFFER_SIZE ( 1600U ) /* This should be larger than TCP packet size. */

  • Question

    • Is the size of PKTIO_READ_BUFFER_SIZE TCP window size?

    It has comment of This should be larger than TCP packet size., but I think it is window size of TCP. Is my understanding correct?

  • Request

    • Is it possible to add (#ifndef PKTIO_READ_BUFFER_SIZE) to be possible the configuration by the config.h file?
@chinglee-iot chinglee-iot self-assigned this May 23, 2024
@chinglee-iot
Copy link
Member

@KeitaKashima
Thank you for reporting this issue.

You're correct in your understanding. The comment should describe the maximum AT command response size, which is typically the TCP socket receive command response packet size. This should be configurable according to the modem specification. We will create a PR to expose this configuration.

@chinglee-iot
Copy link
Member

@KeitaKashima
We've created a PR to address this issue #173. It would be great if you can also help to test this PR.

@KeitaKashima
Copy link
Author

@chinglee-iot

Thank you for fixing this portion.

I could redefine the PKTIO_READ_BUFFER_SIZE in my config.h.
And it is working fine!

<cellular_config.h>

image

The pketioReadBuf value is set correctly as I set 4096+1 .

image

@chinglee-iot
Copy link
Member

chinglee-iot commented May 28, 2024

Thank you for your verification. This issue will be closed when the PR is merged. Feel free to reopen this issue or create another one if you have further question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants