Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review DPO EQ defs and assign to uPheno patterns #13

Open
matentzn opened this issue Jul 9, 2019 · 9 comments
Open

Review DPO EQ defs and assign to uPheno patterns #13

matentzn opened this issue Jul 9, 2019 · 9 comments
Assignees

Comments

@matentzn
Copy link
Collaborator

matentzn commented Jul 9, 2019

For this or the next VFB ontology call, it would be good to do the following:

  1. Review all the tsv files in the original pipeline -> @dosumis suggests to do this carefully together with dpo paper, phenotype by phenotype. If you want, you can put the four tables into a google sheets for easier collaboration; thats how we did it with the other MODs
  2. Assign all phenotypes in these spreadsheets to appropriate uPheno patterns; maybe best to suggest an appropriate pattern and then review with @dosumis
  3. The outcome should be that all or most of the phenotypes are in tsv files that are named after there corresponding uPheno pattern, for example abnormalAnatomicalEntity.tsv
  4. Once @dosumis gives me the go, I will switch the patterns to the standard pipeline
@matentzn
Copy link
Collaborator Author

matentzn commented Jul 9, 2019

@dosumis raised a special concern about the use of inheres_in_part_of in the abnormalBehaviour pattern; this discussion should be had on the uPheno level ideally, so that all groups can input (especially since behavioural phenotypes might be one of the next big things :P)

You can find the current (undocumented, i.e. no metadata) patterns in the src/patterns/dosdp-patterns directory for reference.

@matentzn
Copy link
Collaborator Author

matentzn commented Jul 9, 2019

(this does NOT have to happen before this weeks release!)

@Clare72
Copy link
Collaborator

Clare72 commented Jul 10, 2019

Would it be easy to populate the _label columns? This would make review easier.

@matentzn
Copy link
Collaborator Author

This is akaik unfortunately not currently possible (dosdp-tools limitation). But I made a ticket to make this possible in the future.

@matentzn
Copy link
Collaborator Author

Note to self: Example pattern support dxrefs can be found here.

Not sure whether the dosdp tools matching mechanism copes with that kind of granularity, but we will see after the pattern review is completed.

@dosumis
Copy link
Collaborator

dosumis commented Jul 12, 2019

Not sure whether the dosdp tools matching mechanism copes with that kind of granularity, but we will see after the pattern review is completed.

Pretty sure it doesn't - but we can relatively easily extract annotations from the JSON version, given IDs/IRIs for the terms.

@Clare72
Copy link
Collaborator

Clare72 commented Jul 25, 2019

Finished moving phenotypes to abnormalAnatomicalEntity, abnormalBiologicalProcess and abnormalBehavior.

By the way our 'thermotaxis behavior defective' is not a 'behavior defective' as GO:'thermotaxis' is not a behavior, so I will make a ticket to rename this to 'thermotaxis defective'.

@matentzn
Copy link
Collaborator Author

@Clare72 Can you just copy paste the ones here in the ticket that still need doing (apart from lethal)?

@Clare72
Copy link
Collaborator

Clare72 commented Jan 11, 2021

Todo list:
#24
#22
#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants