-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review DPO EQ defs and assign to uPheno patterns #13
Comments
@dosumis raised a special concern about the use of inheres_in_part_of in the abnormalBehaviour pattern; this discussion should be had on the uPheno level ideally, so that all groups can input (especially since behavioural phenotypes might be one of the next big things :P) You can find the current (undocumented, i.e. no metadata) patterns in the src/patterns/dosdp-patterns directory for reference. |
(this does NOT have to happen before this weeks release!) |
Would it be easy to populate the _label columns? This would make review easier. |
This is akaik unfortunately not currently possible (dosdp-tools limitation). But I made a ticket to make this possible in the future. |
Note to self: Example pattern support dxrefs can be found here. Not sure whether the dosdp tools matching mechanism copes with that kind of granularity, but we will see after the pattern review is completed. |
Pretty sure it doesn't - but we can relatively easily extract annotations from the JSON version, given IDs/IRIs for the terms. |
Finished moving phenotypes to abnormalAnatomicalEntity, abnormalBiologicalProcess and abnormalBehavior. By the way our 'thermotaxis behavior defective' is not a 'behavior defective' as GO:'thermotaxis' is not a behavior, so I will make a ticket to rename this to 'thermotaxis defective'. |
@Clare72 Can you just copy paste the ones here in the ticket that still need doing (apart from lethal)? |
For this or the next VFB ontology call, it would be good to do the following:
The text was updated successfully, but these errors were encountered: