Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Breaking change for flagSrc and unexpected value (LanguageMenu) #1890

Open
gtitze opened this issue Nov 17, 2023 · 0 comments
Open

BUG: Breaking change for flagSrc and unexpected value (LanguageMenu) #1890

gtitze opened this issue Nov 17, 2023 · 0 comments

Comments

@gtitze
Copy link

gtitze commented Nov 17, 2023

I have checked that the bug exists in the dev-development branch
Yes.

I have checked that there are no already open issues or recently closed issues about this bug
Yes.

Describe the bug
Variable flagSrc for a language rendered by the LanguageMenuViewHelper does not contain the src of the image (anymore).

Until version v6.0.5 (and still in December 2021 on the development branch working fine for v11), the variable flagSrc of every language returned the src of the flag image which could then be used to render the image. Since commit ca9bbe4, the variable containes the HTML code of the rendered image.

To Reproduce

  1. Use LanguageMenuViewHelper with layout flag for v7.0.1 oder dev-development
  2. Inspect the variable flagSrc of any language item

Expected behavior
I would expect to get the actual image path from this variable, as it was before, and I could not find any documentation underlining that this change was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant