New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define and document naming conventions and rename misaligned classes #2091

Open

kaltokri opened this issue Jan 3, 2024 · 0 comments

Assignees

Collaborator

kaltokri commented Jan 3, 2024 •

edited

Loading

Some examples:

Fsm / Atis / Fox vs. AWACS / CSAR / CTLD. AI.AI_A2A_Gci vs. AI.AI_A2G_BAI. -> I suggest upper case for all acronyms.
Why Ops.OpsGroup / Ops.OpsTransport / Ops.OpsZone instead Ops.Group / Ops.Transport / Ops.Zone ?
Core.MarkerOps_Base -> Core.MarkerOpsBase ?
Ops/Intelligence.lua is class Ops.Intel. Rename file to Ops/Intel.lua
Ops.Airwing = Ops.AirWing.lua

ToDos:

We need to define a naming convention.
It must be documented
Check which parts are misaligned to the naming convention
Check if we can change the misaligned parts without breaking downwards compatibility
If a chenage will break downwards compatibility, we need to decide: Do it / don't do it / do it only in development branch

kaltokri assigned kaltokri, funkyfranky and Applevangelist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment