Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save As” is indispensable. #7

Open
y-masutani opened this issue Jul 19, 2024 · 4 comments
Open

"Save As” is indispensable. #7

y-masutani opened this issue Jul 19, 2024 · 4 comments

Comments

@y-masutani
Copy link

After changing the contents of the Name field in the Behavior Dashboard, the following warning is displayed and a new Behavior and Manifest file cannot be created.

Screenshot from 2024-07-19 19-50-40

I cannot understand the following message in it:

You may change behavior package selection (to something else and back) to rest file names and create a new behavior file as a copy of this one.

This is very inconvenient. I would like a “Save As” function.

In the case of FlexBE App, it is possible to do so.

@dcconner
Copy link
Member

dcconner commented Jul 19, 2024

In the case of FlexBE App, it is possible to do so.

OK... I had forgotten that changing a name in App automatically created a new file.

I'm not sure we want that if you just fix a typo in name, you would have two behaviors .

There is not a "Save As" in the menu, and in the WebUI changing the Behavior Name does not automatically create a new file.

The work around for "Save As" is if you change the package selection it will reset the file names, so changing the package selection from A to B, then back to A will allow you to create a new file with different name by changing the Behavior name.

So this is effectively "Save As" with an extra step of requiring you to switch package selection twice.

Long term a new "Save As" menu is possible, but the message was intended as a way to get the functionality out quickly.

@y-masutani
Copy link
Author

I'm not sure we want that if you just fix a typo in name, you would have two behaviors .

There is not a "Save As" in the menu, and in the WebUI changing the Behavior Name does not automatically create a new file.

If you fix the typo in the name, the typo in the file name is still there. This is not a happy situation.

In FlexBE App and WebUI, the Python and XML file names are determined from the behavior name at the beginning, so If the behavior name is changed, it would be more straightforward that the file name is also changed. In other words, my opinion is that the FlexBE App specification is better.

The work around for "Save As" is if you change the package selection it will reset the file names, so changing the package selection from A to B, then back to A will allow you to create a new file with different name by changing the Behavior name.

I finally figured out how to do this. However, I found it difficult to understand.

@dcconner
Copy link
Member

The change from FlexBE App was somewhat accidental, but I don't think the App approach of creating multiple variations of the behavior is ideal either.

My thinking on this now is to add a pop-up whenever the name (filename) changes and give the user the option to

  • 'save as' with new file
  • rename existing files
  • just change the text name, but not the file name

I have other priorities over the coming weeks, so this may not get implemented in the first official release.

@y-masutani
Copy link
Author

My thinking on this now is to add a pop-up whenever the name (filename) changes and give the user the option to

  • 'save as' with new file
  • rename existing files
  • just change the text name, but not the file name

Your idea sounds good. I look forward to the new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants