-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exometer cached value potentially not deleted when expired #105
Comments
Actually I see that the piece of code that I understand it is supposed to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a process calls
exometer_cache:write/{3,4}
, it:exometer_cache
process to start a timer for the (metric-datapoint keyed) cache deletion, and to update (ets:update_element
) the relevant field in the ETS entry with the timer ref;ets:insert
) the ETS entry, without timer ref.Depending on the scheduling of the process calling
exometer_cache:write
and theexometer_cache
process (I am excluding process death for simplicity), the cache ETS entry may or may not have the timer ref.If the cache ETS entry has no timer ref, the cache ETS entry is not deleted when the timer fires.
A following
exometer_cache:write
may update the cache ETS entry, though it looks to me this is not the intended behaviour hence the report.Sample minimal example (notice the
ets:select_delete
calls):The text was updated successfully, but these errors were encountered: