Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode warnings present #23

Open
jnigro opened this issue Sep 8, 2018 · 0 comments
Open

Xcode warnings present #23

jnigro opened this issue Sep 8, 2018 · 0 comments

Comments

@jnigro
Copy link

jnigro commented Sep 8, 2018

Hi! When I started using Xcode 10, I took the opportunity to update my project to use your latest version of the SDK. However, some warnings have now appeared. Below I am including them and the code changes necessary to make them disappear:

In file FsprgEmbeddedStoreController.m, the following line, produces error: Macro expansion producing 'defined' has undefined behaviour:

#define RETRIEVE_SSL_CERTIFICATES defined(MAC_OS_X_VERSION_10_6) && MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_6

Fixed by changing code to:

#if defined(MAC_OS_X_VERSION_10_6) && MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_6
    #define RETRIEVE_SSL_CERTIFICATES 1
#else
    #define RETRIEVE_SSL_CERTIFICATES 0
#endif

In class FsprgOrder, selector orderFromData, variable declaration errorDesc produces warning: Unused variable 'errorDesc'. It can be fixed by moving it inside the #if-then section, from:

NSString *errorDesc = nil;

#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_6
    

to

#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_6
    NSString *errorDesc = nil;

I would appreciate if you could incorporate these changes, so my code can be in sync with your repository. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant