-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] [FuncEnv
] Add params
argument to __init__
#905
Labels
Comments
Kallinteris-Andreas
changed the title
[Proposal] Add
[Proposal] [Feb 3, 2024
params
argument to FuncEnv
FuncEnv
] Add params
argument to __init__
Since 1.0 has been released, will this be worked on? I am in the same boat (writing MJX envs). Is there any workaround for now? |
@pulak-gautam would you like to make a PR for this |
Yes, more than happy to! I'll start working on it and submit the PR shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal
Currently, the
__init__
function does not take theparams
argument, instead it takes theoptions
argumentGymnasium/gymnasium/functional.py
Lines 49 to 52 in f88a618
But the
params
of the environment are needed to initialize the object (such as to setobservation_space
member variable)additional changes requirements:
get_default_params
should be changed to not require the instantiation of the environment to be used as it will be required in__init__
Gymnasium/gymnasium/functional.py
Lines 123 to 125 in de909da
to
and update
FunctionalJaxEnv(gym.Env)
with that change@RedTachyon
Motivation
I have been developing the MJX based environments and this is a requirement
Pitch
No response
Alternatives
If there is no need to the `options' argument, remove it
Additional context
Here are 2 examples of
params
I need for MJXxml_file
indicates the file of the robot model to be used and sets up the internal MuJoCo model and everything else that depends on it like action and observation spacesexclude_current_positions_from_observation
changes, how much of the state space is observable, it is need in__init__()
toobservation_space
and later inobservation()
Checklist
The text was updated successfully, but these errors were encountered: