Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Bans class is used only for creating game ban screens #3904

Open
haykam821 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #3990
Open

The Bans class is used only for creating game ban screens #3904

haykam821 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #3990
Labels
bug Fixes or discusses a bug within the mappings

Comments

@haykam821
Copy link
Contributor

The name of the Bans class implies that it controls bans for multiplayer or the entire game, but that functionality is implemented in the session service and server respectively. This class instead provides ConfirmLinkScreen factory methods based on game ban details. The name and package should be changed accordingly.
@haykam821 haykam821 added the bug Fixes or discusses a bug within the mappings label Jun 27, 2024
@Octol1ttle Octol1ttle linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change: rename Bans to AccountBanScreens Octol1ttle/yarn
1 participant
@haykam821