Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

develop/events#adding-items-to-the-loot-table uses v2 instead of v3 #199

Open
AngerVon2468 opened this issue Oct 20, 2024 · 2 comments
Open

develop/events#adding-items-to-the-loot-table uses v2 instead of v3 #199

AngerVon2468 opened this issue Oct 20, 2024 · 2 comments
Labels
correction Something isn't right on a page needs-discussion Further discussion is needed

Comments

@AngerVon2468
Copy link

image
In the above image, the LootTableEvents.MODIFY.register() parameters do not match the actual parameters in the code. See below for the actual parameters.
image
(ignore my ugly theme)
@AngerVon2468
Copy link
Author

(I forgot to link the exact page so https://docs.fabricmc.net/develop/events#adding-items-to-the-loot-table)

@its-miroma its-miroma added correction Something isn't right on a page stage:verification This should be verified labels Oct 21, 2024
@its-miroma
Copy link
Member

You're probably using v3, which needs registries, but v2 (deprecated, but used in that file for some reason) does not.

Sources:

The question is: why are we using v2? @FabricMC/documentation

@its-miroma its-miroma added needs-discussion Further discussion is needed and removed stage:verification This should be verified labels Oct 21, 2024
@its-miroma its-miroma changed the title Parameters for LootTableEvents in wiki example don't match actual parameters develop/events#adding-items-to-the-loot-table uses v2 instead of v3 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correction Something isn't right on a page needs-discussion Further discussion is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngerVon2468 @its-miroma