Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module syntax line not correctly ended #19

Open
maxzinkus opened this issue Dec 2, 2019 · 2 comments
Open

module syntax line not correctly ended #19

maxzinkus opened this issue Dec 2, 2019 · 2 comments

Comments

@maxzinkus
Copy link
Contributor

module Foo
open Bar
open Baz

will not correctly highlight the first open. However,

module Foo (* quux *)
open Bar
open Baz

will correctly color everything. I assume this means the module region isn't correctly ending.

@maxzinkus
Copy link
Contributor Author

The nextgroup for fstarModule is fstarPreDef, which looks like this:
fstarPreDef start="."me=e-1 matchgroup=fstarKeyword end="\l\|=\|)"me=e-1
I feel like this region (start on any character, end on lowercase, =, or ) is wrong.

@maxzinkus
Copy link
Contributor Author

Ah, no, I think the actual fix for this is to change fstarModule's end from end="\<\u\(\w\|'\)*\>" to end="\<\u\(\w\|'\)*\>"me=e-1 to prevent the word-ending \> match from consuming the newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant