Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of complex id, and assignment of primitive instances generally #1526

Open
cmoesel opened this issue Oct 8, 2024 · 0 comments

Comments

@cmoesel
Copy link
Member

cmoesel commented Oct 8, 2024

If an entity’s id is an object and not just a string, it can produce errors and undesirable results. As long as that object has a “value” attribute, we should be able to use that attribute for the actual string. This only happens when assigning an inline instance of string to “id”.

The right thing to do is to make it so that the value ends up on the actual “id” and the other parts end up on “_id”.

While we discovered this with id, this is applicable when assigning any inline instance of a primitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant