Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPM setup.py missing setup_requirements.txt reference missing #958

Open
ssorenso opened this issue Sep 25, 2017 · 0 comments
Open

RPM setup.py missing setup_requirements.txt reference missing #958

ssorenso opened this issue Sep 25, 2017 · 0 comments
Assignees
@ssorenso
Labels
bug P3 S4

Comments

@ssorenso
Copy link

  • Title: RPM setup.py missing setup_requirements.txt reference missing
  • Attachments:
  • Details: Just simply missing the universal truth aspect in the setup.py

OpenStack Release

All supported

Description

Somehow I missed inserting the setup_requirements.txt handling in the setup.py file.

Agent Version

liberty; mitaka; newton

Operating System

All that use pip's install methodology
@ssorenso ssorenso self-assigned this Sep 25, 2017
ssorenso pushed a commit to ssorenso/f5-openstack-agent that referenced this issue Sep 25, 2017
@sorensF5
setup.py missing universal truth in setup_req*.txt
c0cb4bb 
Issues:
Fixes F5Networks#958

Problem:
* `setup_requirements.txt` missing from `setup.py`

Analysis:
* This adds it and allows for pip library to exist for redhat and ubuntu
  * Both required for build Dockerfile's

Tests:
This is driven by the:
`./f5-openstack-agent-dist/scripts/test_install.sh`
Test script for building packages and validating them.
@ssorenso ssorenso mentioned this issue Sep 25, 2017
Closed
ssorenso pushed a commit to ssorenso/f5-openstack-agent that referenced this issue Sep 26, 2017
@sorensF5
setup.py missing universal truth in setup_req*.txt
f601555 
Issues:
Fixes F5Networks#958

Problem:
* `setup_requirements.txt` missing from `setup.py`

Analysis:
* This adds it and allows for pip library to exist for redhat and ubuntu
  * Both required for build Dockerfile's

Tests:
This is driven by the:
`./f5-openstack-agent-dist/scripts/test_install.sh`
Test script for building packages and validating them.
@richbrowne richbrowne added P3 and removed P2 labels Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssorenso ssorenso

Labels
bug P3 S4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ssorenso @dflanigan @richbrowne