Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BannerPatternsComponent not working #254

Open
dan28000 opened this issue Oct 20, 2024 · 0 comments
Open

BannerPatternsComponent not working #254

dan28000 opened this issue Oct 20, 2024 · 0 comments

Comments

@dan28000
Copy link

Describe the bug
when using cursor to move a banner around in inventory and having a listener for WindowItems and reading items from that packet it visually clears the banner of any patterns this only happens on 1.20.5+

aside from that when doing this and checking components on the item when using cursor to move banner around it shows as BlockEntityDataComponent but when sending a custom WindowItems packet with banners inside from the server it shows as BannerPatternsComponent that are all empty

To Reproduce

  1. register WindowItems listener
    example code
@Override
public void packetReceive(PacketReceiveEvent<WindowItems> e) {
     WindowItems packet = e.packet();

     short windowId = packet.windowId();
     int stateId = packet.stateId();
     packet.items().stream()
           .filter(Objects::nonNull)
           .map(BaseItemStack::getComponents)
           .forEach(System.out::println);
}
  1. move any banner with patterns around in the inventory on the server using cursor
  2. it should visually lose all patterns

Expected behavior
when moving banners around in inventory patterns should stay intact

Screenshots
If applicable, add screenshots to help explain your problem.

Proxy environment
velocity running with latest protocollize - 2.4.1:1220, luckperms and my custom plugin that registers the listener

Minecraft versions used
server running latest purpur 1.21.1
client 1.20.4 and 1.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant