Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oceananigans Flux BC with Enzyme Cannot deduce type of insertvalue ins #2083

Open
jlk9 opened this issue Nov 11, 2024 · 2 comments
Open

Oceananigans Flux BC with Enzyme Cannot deduce type of insertvalue ins #2083

jlk9 opened this issue Nov 11, 2024 · 2 comments

Comments

@jlk9
Copy link
Collaborator

jlk9 commented Nov 11, 2024

When I run this code (https://github.com/glwagner/Enzymanigans.jl/blob/main/dynamical_core/autodiff_double_gyre.jl) I get the error included in the attached file: fluxbcerror.txt

Commenting out the inclusion of a flux boundary condition in the model, i.e. at this line:

https://github.com/glwagner/Enzymanigans.jl/blob/c945994b0e0fca400bf3c5207d55d6862b458b7c/dynamical_core/autodiff_double_gyre.jl#L63

eliminates the error.

Specifying Enzyme.API.looseTypeAnalysis!(true) does not change the error. Neither does setting the model grid or clock structs to inactive. (The changes are no longer needed in other differentiable Oceananigans scripts either.)

@wsmoses

@jlk9 jlk9 changed the title Enzyme Flux BC Cannot deduce type of insertvalue ins Oceananigans Flux BC with Enzyme Cannot deduce type of insertvalue ins Nov 11, 2024
@wsmoses
Copy link
Member

wsmoses commented Nov 12, 2024

will investigate

@wsmoses
Copy link
Member

wsmoses commented Nov 13, 2024

@jlk9 so I can't reproduce this with latest Enzyme (and hypothesize it was fixed by my improvements to type analysis I built for 1.10 [but apply to 1.11])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants