Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up testing mechanism #48

Open
serdardalgic opened this issue Nov 10, 2022 · 1 comment
Open

Set up testing mechanism #48

serdardalgic opened this issue Nov 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@serdardalgic
Copy link
Contributor

serdardalgic commented Nov 10, 2022

Testing GH Action workflow https://github.com/EnterpriseDB/terraform-provider-biganimal/blob/main/.github/workflows/test.yml is disabled for now. We need to enable it.

Moreover, we need to provide more details on how we test, what we test. Currently, we have a vague description of testing here:

Your change should include unit tests and regression tests to protect your feature or other features from breaking. Please make sure

* that tests follow the conventions of existing ones;
* for new features, to cover as many inputs/configurations as possible.

Related reading: https://developer.hashicorp.com/terraform/plugin/sdkv2/testing

@serdardalgic serdardalgic added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 29, 2022
@YanniHu1996 YanniHu1996 self-assigned this Feb 14, 2023
@serdardalgic
Copy link
Contributor Author

As of the end of July 2023, we have the following Acceptance Tests

Those are very basic tests, and they don't cover updating all the fields. But it's a good start for now.

The next steps would be:

  • Improving the tests to cover certain cases, for example: updating a cluster field and ensuring the update is applied, or covering the cases where the cluster should not be updated e.g. changing the
  • Improving the tests to cover the creation of the resources on different CSPs and different hosting opportunities(BYOA v.s. BAH).
  • How to run the acceptance tests regularly (an internal discussion within EDB would be necessary for that)
  • Integrating acceptance tests to the release process (running them for every release)

After creating tickets for the necessary items, I'd like to close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
Development

No branches or pull requests

2 participants