Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of cloud_provider for other fields #135

Open
bryan-bar opened this issue Feb 10, 2023 · 0 comments
Open

Reuse of cloud_provider for other fields #135

bryan-bar opened this issue Feb 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bryan-bar
Copy link

bryan-bar commented Feb 10, 2023

Is your feature request related to a problem? Please describe.
We are defining the cloud_provider and then having to specify it in again under other schema inputs and think the provider should handle this instead.
For example:

instance_type = "azure:Standard_D2s_v3"
storage {
    volume_type       = "azurepremiumstorage"
    volume_properties = "P1"
    size              = "4 Gi"
  }
cloud_provider        = "azure"
region                = "eastus2"

Here we define azure:Standard_D2s_v3 and azurepremiumstorage

instance_type = "aws:c5.large"
storage {
    volume_type       = "gp3"
    volume_properties = "gp3"
    size              = "4 Gi"
  }
cloud_provider        = "aws"
region                = "us-east-1"

Here we define aws:c5.large

Describe the solution you'd like
I think we should remove the cloud provider prefixes or hide it from the user and reuse cloud_provider.

Describe alternatives you've considered
With edb-terraform, we use jinja for templating and so we could hide some of this from the user with mappings and/or string concatenation.

@bryan-bar bryan-bar added the enhancement New feature or request label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant