Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race between setting this.message and removing the message popup #31

Open
Enigmatrix opened this issue Aug 18, 2019 · 3 comments
Open
Labels

Comments

@Enigmatrix
Copy link
Owner

There is a race between the actions of the last message sent and the next completed message. This is due to the setting of the message only having actions on the next Vue tick. Need to find how to detect when the message is sent to the dom and then remove the popup afterwards.

@Enigmatrix
Copy link
Owner Author

Enigmatrix commented Aug 22, 2019

Perhaps setting list enter/leave animations will let the pop-up live longer, enough to set the this.message without triggering the race.

@daniellimws
Copy link
Collaborator

🤨 Can you queue the actions instead

@Enigmatrix
Copy link
Owner Author

Actually possible using Vue.nextTick, I'll give it a try (and add sexy anime after 😉)

Enigmatrix added a commit that referenced this issue Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants