Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StackOverFlowException] Limit the retry routines using numbers or boolean flags #32

Open
pavly-gerges opened this issue Aug 25, 2024 · 0 comments
Labels
core Core API related stuff defect A defect in the system (not a bug!). good first issue Good for newcomers

Comments

@pavly-gerges
Copy link
Member

pavly-gerges commented Aug 25, 2024

It's noticed that whenever running jSnapLoader's NativeBinaryLoader with an enabled default retry criteria, two possible events could take place:

  • A Finite-machine that terminates with extraction and loading of the native binary, with the predicate that the Jar and library should exist and are not corrupted.
  • A Finite-machine that stalls with recursive calls to the loading machine leading to StackOverFlow exceptions and potential memory leaks could take place at this stage.

The proposed fix:

  • Control the number of the recursive machines via an atomic integer.
  • Provide the appropriate conditional predicates to test the filesystem archive before starting the extraction and loading automata.
@pavly-gerges pavly-gerges added core Core API related stuff defect A defect in the system (not a bug!). labels Aug 25, 2024
@pavly-gerges pavly-gerges added this to the 1.1.0-stable Release milestone Aug 25, 2024
@pavly-gerges pavly-gerges added the good first issue Good for newcomers label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core API related stuff defect A defect in the system (not a bug!). good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant