Update Client Service to enable Regulator for transfers #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugypalu
approved these changes
Feb 7, 2023
imagobea
suggested changes
Feb 7, 2023
There was a problem hiding this comment.
Only requesting changes so that we can discuss some of the comments and take a look at the test with the SDK.
I could follow more or less the implementation till I got to the circuit part! 🙈 We need to find a place to document this in a simple but comprehensive way.
Once the feature evolves, we should add more test. If possible, I would create new test suites instead of adding more cases to erc-tokens.
We should test that a 3rd party can open the commitment and access the data as intended. But cannot spend commitments. Etc etc.
Great work indeed!! 💪 It is nice to see others adventuring into the circuits layer. Well done 👏
imagobea
approved these changes
Feb 9, 2023
israelboudoux
suggested changes
Feb 9, 2023
israelboudoux
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Update in the client to enable regulator for the transfers.
Does this close any currently open issues?
#1372
What commands can I run to test the change?
Start nightfall with
REGULATOR_URL=http://localhost:8080 NF_SERVICES_TO_START=blockchain,client,worker,optimist,deployer ./bin/start-nightfall -g -dto indicate a regulator url for the client to create transfers enabled for the regulator.npm run unit-test-circuitsnpm run test-general-stuffREGULATOR_URL=http://localhost:8080 NF_SERVICES_TO_START=blockchain,client,deployer,optimist,worker ./bin/start-nightfall -g -d)Any other comments?
This is part of the regulator feature and the part for the regulator service is simulated now, waiting for the corresponding PR that will be merged in this feature branch and then integrated.